[Microsoft integration] getFullMessageList #9544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implemented Microsoft Graph API integration for message fetching, adding support for retrieving email messages from Microsoft 365 alongside the existing Gmail integration.
- Fixed incorrect
MESSAGING_MICROSOFT_USERS_MESSAGES_LIST_MAX_RESULTvalue in/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/services/microsoft-get-message-list.service.ts(set to 1 instead of 1000) - Missing error handling for Microsoft Graph API calls in
microsoft-get-message-list.service.ts - Using beta API version instead of stable in Microsoft Graph API calls
- Incomplete
getPartialMessageListimplementation for Microsoft provider returns empty values - Incorrect redirect URIs in documentation referencing Google endpoints instead of Microsoft ones
7 file(s) reviewed, 9 comment(s)
Edit PR Review Bot Settings | Greptile
...endar/calendar-event-import-manager/crons/commands/calendar-event-list-fetch.cron.command.ts
Outdated
Show resolved
Hide resolved
...es/messaging/message-import-manager/drivers/microsoft/providers/microsoft-client.provider.ts
Outdated
Show resolved
Hide resolved
...ging/message-import-manager/drivers/microsoft/services/microsoft-get-message-list.service.ts
Outdated
Show resolved
Hide resolved
...es/messaging/message-import-manager/drivers/microsoft/providers/microsoft-client.provider.ts
Outdated
Show resolved
Hide resolved
...ging/message-import-manager/drivers/microsoft/services/microsoft-get-message-list.service.ts
Show resolved
Hide resolved
Comment on lines
+34
to
+40
| const response: PageCollection = await microsoftClient | ||
| .api(syncCursor || '/me/mailfolders/inbox/messages/delta?$select=id') | ||
| .version('beta') | ||
| .headers({ | ||
| Prefer: `odata.maxpagesize=${MESSAGING_MICROSOFT_USERS_MESSAGES_LIST_MAX_RESULT}`, | ||
| }) | ||
| .get(); |
There was a problem hiding this comment.
logic: No try-catch block around API call that could fail due to network issues or invalid tokens
There was a problem hiding this comment.
only interesting thing we might talk out loud
...ules/messaging/message-import-manager/drivers/microsoft/messaging-microsoft-driver.module.ts
Outdated
Show resolved
Hide resolved
...ules/messaging/message-import-manager/drivers/microsoft/messaging-microsoft-driver.module.ts
Outdated
Show resolved
Hide resolved
packages/twenty-website/src/content/developers/self-hosting/setup.mdx
Outdated
Show resolved
Hide resolved
charlesBochet
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation of the GmailGetMessageListService
Implementation of the driver to MS Graph API getFullMessageList